馃悰 Move ampDoc references into amp-story buildCallback #30986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet, @newmuis, @Enriqe! These files were changed: |
gmajoulet
approved these changes
Nov 3, 2020
| @@ -1003,7 +1009,7 @@ export class AmpStory extends AMP.BaseElement { | |||
| // Preloads and prerenders the share menu. | |||
| this.shareMenu_.build(); | |||
|
|
|||
| const infoDialog = shouldShowStoryUrlInfo(this.viewer_) | |||
| const infoDialog = this.viewer_ && shouldShowStoryUrlInfo(this.viewer_) | |||
There was a problem hiding this comment.
The viewer should always be defined at this point. This is dangerous because it means that infoDialog would be false if the viewer is not defined, without any error message. If you want to satisfy the compiler, please use devAssert().
There was a problem hiding this comment.
devAssert() is making sense now. Thanks Gabriel!
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* Move methods that need ampdoc to buildCallback. * Update types. * Remove const * Fix typo. * devAssert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context / fixes #30798