Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: 📖 remove amp by example, since it deprecated/dead. #31014

Merged
merged 2 commits into from Nov 5, 2020
Merged

docs: 📖 remove amp by example, since it deprecated/dead. #31014

merged 2 commits into from Nov 5, 2020

Conversation

samouri
Copy link
Member

@samouri samouri commented Nov 5, 2020 •
edited

Two options:

  1. delete
  2. change to indicate folks may consider adding examples to amp.dev

Sound off in the comments below.

@samouri samouri self-assigned this Nov 5, 2020
@samouri samouri mentioned this pull request Nov 5, 2020
Merged
caroqliu
caroqliu approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@caroqliu caroqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote to update the links with amp.dev :) Thanks for keeping our documentation fresh!

@samouri samouri requested a review from caroqliu November 5, 2020 15:44
@samouri
Copy link
Member Author

samouri commented Nov 5, 2020

I vote to update the links with amp.dev :) Thanks for keeping our documentation fresh!

Updated to point to amp.dev instead of deleting. PTAL

@samouri samouri merged commit 9a08783 into ampproject:master Nov 5, 2020
@samouri samouri deleted the rm-ampbyexample branch November 5, 2020 16:13
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
@samouri @ed-bird
docs: 📖 remove amp by example, since it deprecated/dead. (ampproject#…
9b1111a 
…31014)

* docs: remove amp by example, since it is a dead link.

* actually dont remove, point to amp.dev instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caroqliu caroqliu caroqliu approved these changes

Assignees

@samouri samouri

Labels
PR use: In Beta / Experimental Related to: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samouri @caroqliu @ampprojectbot