馃摉 Guidelines for naming third-party components #31267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of these guidelines have been followed by convention, but never been written down. Hopefully this clears up some confusion.
alanorozco
requested review from
kristoferbaxter,
CrystalOnScript and
zhouyx
zhouyx
approved these changes
Nov 19, 2020
caroqliu
approved these changes
Nov 19, 2020
CrystalOnScript
approved these changes
Nov 19, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
Some of these guidelines have been followed by convention, but never been written down. Hopefully this clears up some confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these guidelines have been followed by convention, but never been written down. Hopefully this clears up some confusion.