Reuse dom.childElements and dom.childNodes #3145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cramforce Could you also have a look? |
|
Anyone know why this is failing? |
| * These nodes can include Text, Comment and other child nodes. | ||
| * @param {!Node} parent | ||
| * @param {function(!Node):boolean} callback | ||
| * @return {!Array.<!Node>} |
|
This looks good thanks! Few comments. |
muxin
force-pushed
the
reuse-childElements-childNodes
branch
from
a4f991c
to
f384d93
Compare
| * @return {!Array<!Node>} | ||
| */ | ||
| export function childNodes(parent, callback) { | ||
| const childnodes = []; |
There was a problem hiding this comment.
nit: call this children or nodes. childnodes doesn't follow the camel-case style and I understand why you didn't use the camel-case here - function name similarity.
|
One more nit! otherwise LGTM |
| @@ -143,6 +143,20 @@ describe('DOM', () => { | |||
| .to.be.equal(0); | |||
| }); | |||
|
|
|||
| it('childNodes should find all matches', () => { | |||
There was a problem hiding this comment.
Please add a not-all-positive test as well.
|
LGTM from my side. |
|
👍 LGTM, please wait for the tests and then merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3115