Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getChangeIntersectionEntry from LegacyAdIntersectionObserverHost #31693

Merged
merged 11 commits into from
Dec 29, 2020

Conversation

samouri
Copy link
Member

@samouri samouri commented Dec 21, 2020

summary
Replaces the usage of custom-element.getChangeIntersectionEntry with an actual IntersectionObserver. For the fire() call, uses an unobserve/observe pair.

Note: I think we could remove batching since InOb will handle that automatically (a series of many observe/unobserve) pairs in rapid succession will only emit a single event)

Partial for #31540

@samouri samouri changed the title Remove getChangeIntersectionEntry from adintersectionobserverhost Remove getChangeIntersectionEntry from LegacyAdIntersectionObserverHost Dec 22, 2020
@samouri samouri self-assigned this Dec 22, 2020
@samouri samouri marked this pull request as ready for review December 22, 2020 22:06
@samouri
Copy link
Member Author

samouri commented Dec 28, 2020

pushed an empty commit just to rerun owners check. otherwise will merge when it passes

@Tudmotu
Copy link

Tudmotu commented Jan 21, 2021

Hi all,
We started getting null rootBounds objects in 3p iframe (amp-ad). Was there some backward-incompatible change here?

@jridgewell
Copy link
Contributor

@Tudmotu See #32087, we're currently deploying the fix. Should be live today.

@Tudmotu
Copy link

Tudmotu commented Jan 21, 2021

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants