✨[Story devtools] Added functionality to block adding devices if no space #31715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet! These files were changed: |
gmajoulet
approved these changes
Dec 23, 2020
extensions/amp-story-dev-tools/0.1/amp-story-dev-tools-tab-preview.css
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The maximum amount of phones that can be added to the screen is 4, but tablets and desktops will take 2 spaces.
Defined a property
deviceSpaceson all devices that determines how many spaces a device takes. If the sum of the current device spaces and the device we want to add is larger than 4, then the chip button should be disabled.The
data-spacesattribute on chips store how many spaces are required to display a device, and when the AddDeviceDialog is created, it will only set to enabled the devices that have space to be added, or the devices that are added (which are removed when you click on those chips).If there are 4 spaces occupied already, disable adding any new devices:
If there are 3 spaces occupied, only enable the devices that would occupy 1 space (so desktop is disabled):
If there are 2 spaces occupied, enable all the devices to be added:
