[amp-story-player] ✅ Add e2e tests #31716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mszylkowski
approved these changes
Dec 23, 2020
gmajoulet
approved these changes
Dec 23, 2020
| ); | ||
| }); | ||
|
|
||
| it('when player becomes visible, third story starts preloading', async () => { |
There was a problem hiding this comment.
Hopefully we'll make this test fail soon and only prerender N+1 :))
Enriqe
force-pushed
the
player-e2e-tests
branch
from
c405f62
to
aa6f874
Compare
|
Owners check bot bump |
Enriqe
force-pushed
the
player-e2e-tests
branch
from
aa6f874
to
a83f435
Compare
|
onwers bot bump |
Enriqe
force-pushed
the
player-e2e-tests
branch
from
a83f435
to
f354051
Compare
rcebulko
reviewed
Dec 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31276
Adds e2e tests for the player.