Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✂️ Remove getPageLayoutBox API #31754

Merged
merged 1 commit into from
Dec 29, 2020
Merged

✂️ Remove getPageLayoutBox API #31754

merged 1 commit into from
Dec 29, 2020

Conversation

dvoytenko
Copy link
Contributor

@dvoytenko dvoytenko commented Dec 28, 2020 •
edited

Partial for #31540

@amp-owners-bot
Copy link

Hey @jeffkaufman! These files were changed:

extensions/amp-ad-network-doubleclick-impl/0.1/test/test-doubleclick-safeframe.js

@dvoytenko dvoytenko changed the title Remove getPageLayoutBox API ✂️ Remove getPageLayoutBox API Dec 28, 2020
samouri
samouri approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@samouri samouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woooot!

@dvoytenko dvoytenko merged commit 3c710dd into ampproject:master Dec 29, 2020
@dvoytenko dvoytenko deleted the run3/remove-page-layout-box branch December 29, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samouri samouri samouri approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dvoytenko @samouri @ampprojectbot