🐛Update validator-amp-base-carousel.protoascii with 'controls' attribute. Resolves 31872 #31873
Conversation
|
|
|
Hey @ampproject/wg-caching! These files were changed: |
|
@ampproject/wg-components can you confirm that this is what the WG intended? |
|
@Notebit the reason I'm asking components is because |
|
@honeybadgerdontcare I am a complete newbie, so please feel free to do any check you think is necessary. any help is appreciated. |
There was a problem hiding this comment.
Made one suggestion to use regex to support media query style values, copied from the style employed in the rest of the file. Also pinging @micajuine-ho to review.
extensions/amp-base-carousel/validator-amp-base-carousel.protoascii
Outdated
Show resolved
Hide resolved
|
ping @ampproject/wg-caching |
|
@caroqliu what is the ping for? |
|
@Gregable for validator file review |
|
thanks everybody for the prompt support |
…ute. Resolves 31872 (ampproject#31873) * Update validator-amp-base-carousel.protoascii Missing "controls" attribute https://amp.dev/documentation/components/amp-base-carousel/?format=websites#controls * Support media query syntax https://amp.dev/documentation/components/amp-base-carousel/#media-queries Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com>
* cl/354149380 Revision bump for #31873 * cl/354558578 Deprecate `lang` attribute on `doctype`. * cl/354593816 Revision bump for #32262 * revert duplicate controls * cl/354600080 Revision bump for #32288 * cl/355043682 n/a Co-authored-by: Greg Grothaus <greggrothaus@google.com> Co-authored-by: Amaltas Bohra <amaltas@google.com>
Missing "controls" attribute, which is can take a media query to resolve to its value as one of
"auto"|"always"|"never".https://amp.dev/documentation/components/amp-base-carousel/?format=websites#controls
Example valid value in media query format:
(min-width: 1000px) always, (min-width: 600px) never, alwaysResolves #31872