✨ Bento Lightbox: scrollable feature
#32145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
suggested changes
Jan 22, 2021
| id="lightbox" | ||
| layout="nodisplay" | ||
| animation={animation} | ||
| scrollable={scrollable} |
There was a problem hiding this comment.
I don't see the attribute mapping anywhere.
There was a problem hiding this comment.
You mean in amp-lightbox.js? It was already there:
dvoytenko
approved these changes
Jan 25, 2021
|
Merging since Circle CI and Travis are green, and the failing |
PetrBlaha
pushed a commit
to PetrBlaha/amphtml
that referenced
this pull request
Jan 28, 2021
* Fix type * Support `scrollable` in Preact * Support scrollable in AMP layer * Update tests * Add comments * Remove root css * Replace overflow: scroll with overflow: auto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the
scrollablefeature forLightbox/amp-lightbox. Related to #31052.Scrolling is allowed within the
Lightboxwith application ofoverflow: scrollas opposed tooverflow: hidden. It also prevents scrolling beyond theLightboxin the outer document with application ofoverscroll-behavior: noneandoverflow: scroll. It appears thatoverflow: hiddenin combination withoverscroll-behavior: nonedoes not yield scroll containment due to over-scrolling not being possible given the lack of overflow.Unfortunately,
overscroll-behavioris only partially supported, so we may need to have more robust approaches such as adding an event listener to the element's root document which callspreventDefaultonscrollwhen theLightboxisopen.