Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator Rollup #32158

Merged
merged 2 commits into from
Jan 23, 2021
Merged

Validator Rollup #32158

merged 2 commits into from
Jan 23, 2021

Conversation

Gregable
Copy link
Member

No description provided.

@amp-owners-bot
Copy link

amp-owners-bot bot commented Jan 23, 2021 •
edited by ampprojectbot

Hey @ampproject/wg-caching! These files were changed:

validator/js/engine/validator.js
validator/testdata/amp4ads_feature_tests/css_i_amphtml.html
validator/testdata/amp4ads_feature_tests/css_i_amphtml.out
validator/testdata/amp4email_feature_tests/css_i_amphtml.html
validator/testdata/amp4email_feature_tests/css_i_amphtml.out
validator/testdata/feature_tests/css_i_amphtml.html
validator/testdata/feature_tests/css_i_amphtml.out
validator/testdata/feature_tests/incorrect_custom_style.out
validator/testdata/feature_tests/media_queries.out
validator/validator-css.protoascii
validator/validator-main.protoascii

@Gregable Gregable merged commit 96e26ac into ampproject:master Jan 23, 2021
@Gregable Gregable deleted the validator-rollup branch January 23, 2021 22:35
micajuine-ho pushed a commit to micajuine-ho/amphtml that referenced this pull request Jan 25, 2021
@honeybadgerdontcare
Validator Rollup (ampproject#32158)
cf84728 
* cl/353344140 Add tests showing i-amphtml is disallowed in CSS, tag and inline

* cl/353344578 Warning-only allow list of CSS media query types and features in amp.

Co-authored-by: honeybadgerdontcare <sedano@google.com>
PetrBlaha pushed a commit to PetrBlaha/amphtml that referenced this pull request Jan 28, 2021
@honeybadgerdontcare @PetrBlaha
Validator Rollup (ampproject#32158)
24a6b83 
* cl/353344140 Add tests showing i-amphtml is disallowed in CSS, tag and inline

* cl/353344578 Warning-only allow list of CSS media query types and features in amp.

Co-authored-by: honeybadgerdontcare <sedano@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honeybadgerdontcare honeybadgerdontcare honeybadgerdontcare approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gregable @honeybadgerdontcare @ampprojectbot