Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Clean up CircleCI config, move some setup steps into separate files #32162

Merged
merged 1 commit into from
Jan 25, 2021
Merged

🏗 Clean up CircleCI config, move some setup steps into separate files #32162

merged 1 commit into from
Jan 25, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jan 24, 2021

PR highlights:

  • Clean up .circleci/config.yml
  • Move cloud storage setup steps to .circleci/setup-storage.sh
  • Move host config for integration tests to build-system/test-configs/hosts
  • Add a check to .circleci/fetch_merge_commit.sh to prevent builds for PRs on other forks (e.g. this build)

Addresses #32051 (comment)

@rsimha rsimha self-assigned this Jan 24, 2021
@rsimha rsimha marked this pull request as ready for review January 25, 2021 14:35
@rsimha rsimha removed the request for review from rcebulko January 25, 2021 14:35
@rsimha rsimha mentioned this pull request Jan 25, 2021
@rsimha rsimha merged commit 6c62105 into ampproject:master Jan 25, 2021
@rsimha rsimha deleted the 2021-01-22-SetupScripts branch January 25, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants