Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize CircleCI builds with a mix of xlarge and large VMs #32174

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Optimize CircleCI builds with a mix of xlarge and large VMs #32174

merged 2 commits into from
Jan 25, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jan 25, 2021

We currently use xlarge CircleCI VMs, which give us a build round trip time of under 20 mins. E.g. this build.

From the pricing chart, xlarge VMs cost 5x as much per minute as large VMs.

Screen Shot 2021-01-25 at 10 03 59 AM

This PR optimizes the price / performance of CircleCI builds by using xlarge VMs for jobs that build the AMP runtime (highly parallelized), and large VMs for all other jobs that run tests (mostly done serially).

@rsimha rsimha self-assigned this Jan 25, 2021
@rsimha
Copy link
Contributor Author

rsimha commented Jan 25, 2021

@rsimha rsimha changed the title Compare CircleCI build time between xlarge and large Optimize CircleCI builds with a mix of xlarge and large VMs Jan 25, 2021
@rsimha rsimha marked this pull request as ready for review January 25, 2021 17:50
@rsimha rsimha removed the request for review from estherkim January 25, 2021 18:57
@kristoferbaxter kristoferbaxter merged commit 2dac223 into ampproject:master Jan 25, 2021
@rsimha rsimha deleted the 2021-01-25-TryLarge branch January 25, 2021 22:29
PetrBlaha pushed a commit to PetrBlaha/amphtml that referenced this pull request Jan 28, 2021
…roject#32174)

* Compare CircleCI build time between xlarge and large
* Use `xlarge` for builds, `large` for tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants