InOb: Force polyfill for WebKit document=root #32182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
suggested changes
Jan 25, 2021
dvoytenko
approved these changes
Jan 26, 2021
PetrBlaha
pushed a commit
to PetrBlaha/amphtml
that referenced
this pull request
Jan 28, 2021
* InOb: Force polyfill for WebKit documnent=root * lint * Use Platform Service. TODO: stub. * Stop using Platform service, use navigator.vendor * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Due to a InOb WebKit bug (https://bugs.webkit.org/show_bug.cgi?id=219495), we should force the InOb polyfill for all WebKit-based browsers. The polyfill already will choose a Native InOb when available + non-document root is requested on a per-instance basis, which works well for this case.
Note: I've never written UA engine detection code before, so I'm still researching now to ensure
WebKitis safe as a regex test.