✨ [bento][amp-date-countdown] Change attribute name of count-up #32201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CrystalOnScript Adding you for changes to documentation :), in case there's anything that I have not worded well! |
dvoytenko
approved these changes
Jan 26, 2021
| @@ -95,7 +95,7 @@ This table provides examples of formatted values specified in a Mustache templat | |||
|
|
|||
| ### Migrating from 0.1 | |||
|
|
|||
| The experimental `1.0` version of `amp-date-countdown` does not support the `data-count-up` attribute. This means the `1.0` component is unable to count in the opposite direction. | |||
| The experimental `1.0` version of `amp-date-countdown` uses the attribute name `count-up` instead of `data-count-up` as in `0.1` to support the `count up` feature. See the `count-up` section under `Attributes` below for more details. | |||
There was a problem hiding this comment.
Nit: "count up" feature.
CrystalOnScript
approved these changes
Jan 27, 2021
Co-authored-by: CrystalOnScript <crystallambert@google.com>
PetrBlaha
pushed a commit
to PetrBlaha/amphtml
that referenced
this pull request
Jan 28, 2021
…roject#32201) * Change attribute name of count-up * Add doc updates for date-countdown * Add quotes to count up in docs * Update extensions/amp-date-countdown/amp-date-countdown.md Co-authored-by: CrystalOnScript <crystallambert@google.com> Co-authored-by: CrystalOnScript <crystallambert@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
data-count-upattribute to be namedcount-up.This matches the rest of the attributes and unlikely to have collision with native attributes since there is a dash in
count-up.Related to: #32047
#32047 (comment)