Move ads vendor configs into a dedicated folder #32218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerivq
force-pushed
the
3p-cross-domain
branch
4 times, most recently
from
5a7bc0a
to
6d44611
Compare
powerivq
force-pushed
the
3p-cross-domain
branch
from
6d44611
to
2693453
Compare
calebcordry
approved these changes
Jan 26, 2021
|
Added @erwinmombay for build-system/test-configs/conformance-config.textproto Moving files only. No changes in the substance. |
erwinmombay
approved these changes
Jan 27, 2021
PetrBlaha
pushed a commit
to PetrBlaha/amphtml
that referenced
this pull request
Jan 28, 2021
powerivq
added a commit
to powerivq/amp.dev
that referenced
this pull request
Feb 8, 2021
Since we moved them on ampproject/amphtml#32218
powerivq
added a commit
to powerivq/amp.dev
that referenced
this pull request
Feb 8, 2021
Since we moved them on ampproject/amphtml#32218
sebastianbenz
pushed a commit
to ampproject/amp.dev
that referenced
this pull request
Feb 8, 2021
Since we moved them on ampproject/amphtml#32218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry it looks scary (522 files), but this should not affect anything yet. It purely moves the files to a different folder. The reason is that I am adding a new build task to build out vendor specific JS separately, so I want them to be separated from global configs (like
_config.js).