Add Bento documentation for amp-date-countdown #32256
Merged
+72
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bento docs for amp-date-countdown
|
@CrystalOnScript or @caroqliu for review. Thank you! |
caroqliu
requested changes
Jan 27, 2021
| </template> | ||
| </amp-date-countdown> | ||
| <div class="buttons" style="margin-top: 8px;"> | ||
| <button id="ar-button">Change locale to Arabic</button> |
There was a problem hiding this comment.
Looks like amp-date-countdown doesn't support Arabic: https://amp.dev/documentation/components/amp-date-countdown/?format=websites#locale-(optional) please replace here and in the click event with a new value.
Comment on lines
+121
to
+122
| layout="fixed-height" | ||
| height="50"> |
There was a problem hiding this comment.
@dvoytenko This sample complains when you remove layout and height FYI
There was a problem hiding this comment.
(We should remove them if we can btw)
Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com>
caroqliu
approved these changes
Jan 27, 2021
Comment on lines
+121
to
+122
| layout="fixed-height" | ||
| height="50"> |
There was a problem hiding this comment.
(We should remove them if we can btw)
Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com>
PetrBlaha
pushed a commit
to PetrBlaha/amphtml
that referenced
this pull request
Jan 28, 2021
* Bento docs for amp-date-countdown Bento docs for amp-date-countdown * Apply suggestions from code review Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * Fix copy pasta errors * Update extensions/amp-date-countdown/amp-date-countdown.md Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> * Travis pliss pass * prettify Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Bento documentation for amp-date-countdown