Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename vendor-configs target to analytics-vendor-configs #32269

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

powerivq
Copy link
Contributor

We are adding a vendor config building step for ads, therefore it seems proper to rename the analytics build task to one with analytics name in it.

Copy link
Contributor

@micajuine-ho micajuine-ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me. Will defer to someone on the infra side for build-system changes.

@powerivq powerivq merged commit 3eb811f into ampproject:master Jan 28, 2021
@powerivq powerivq deleted the rename-vendor-configs branch January 28, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants