Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃彈 Update CircleCI hash for .karma-cache #32312

Merged
merged 2 commits into from
Jan 30, 2021
Merged

馃彈 Update CircleCI hash for .karma-cache #32312

merged 2 commits into from
Jan 30, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jan 29, 2021

In #32295, caching of .karma-cache was reintroduced on CircleCI to speed up unit test runs. However, CircleCI only updates is cache when package-lock.json is changed, while browserify invalidates its cache if any one of several files in build-system is modified.

This PR switches the hash computation in CircleCI to the exact same source used by browserify.

Addresses #32295 (comment)

@rsimha rsimha self-assigned this Jan 29, 2021
build-system/common/browserify-cache.js Outdated Show resolved Hide resolved
@rsimha
Copy link
Contributor Author

rsimha commented Jan 30, 2021

That worked.

Cold cache:
image

Warm cache:
image

@rsimha rsimha merged commit ca438ad into ampproject:master Jan 30, 2021
@rsimha rsimha deleted the 2021-01-29-UpdateKarmaCacheHash branch January 30, 2021 05:34
zaparent pushed a commit to zaparent/amphtml that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants