A version of whenContentLoaded without measurements #32397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @danielrozenberg! These files were changed: |
jridgewell
reviewed
Feb 4, 2021
samouri
approved these changes
Feb 4, 2021
jridgewell
approved these changes
Feb 4, 2021
dvoytenko
force-pushed
the
run3/ini-load-inob
branch
5 times, most recently
from
aea733e
to
0b1bfb7
Compare
dvoytenko
force-pushed
the
run3/ini-load-inob
branch
from
0b1bfb7
to
ba2622a
Compare
rsimha
reviewed
Feb 9, 2021
| opt_isInPrerender | ||
| opt_prerenderableOnly | ||
| ) { | ||
| // eslint-disable-next-line no-undef |
There was a problem hiding this comment.
Seems like this eslint directive is no longer necessary: https://app.circleci.com/pipelines/github/ampproject/amphtml/1495/workflows/2b3584d4-a77c-4bf6-a9d4-fa5e4ebae85e/jobs/14278/parallel-runs/0/steps/0-107
Edit: Fix available in #32538.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #31915.
Partial for #31540.