-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
measureIntersection: use root=document #32402
Conversation
a8a69a5
to
17ea125
Compare
I'm struggling with the failing unit test here. Unsure what My impression was document window's viewport. So for the case of an iframe'd element, width should be: What I'm actually seeing is: |
I think the spec probably spells it out. But off the top of my head, |
summary
root:document
for InObs. Otherwise rootBounds=null.needsRootBounds
be true or false?I recommend viewing the diff without whitespace changes