Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗 Replace logging in gulp bundle-size with output from filesize #32479

Merged
merged 2 commits into from
Feb 8, 2021
Merged

🏗 Replace logging in gulp bundle-size with output from filesize #32479

merged 2 commits into from
Feb 8, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Feb 6, 2021

This PR replaces the custom logging in gulp bundle-size with the built-in output from filesize. With this, we standardize bundle-size output as follows:

Local development:

image

CI builds:

image

Directly running filesize:

image

Companion PR to ampproject/filesize#127
Addresses #32476 (comment)

@rsimha rsimha self-assigned this Feb 6, 2021
@rsimha rsimha changed the title 🏗 Include brotli / uncompressed sizes and ratios in bundle-size output 🏗 Replace custom logging in gulp bundle-size with built-in logging from filesize Feb 6, 2021
@rsimha rsimha changed the title 🏗 Replace custom logging in gulp bundle-size with built-in logging from filesize 🏗 Replace custom logging in gulp bundle-size with output from filesize Feb 6, 2021
@rsimha rsimha changed the title 🏗 Replace custom logging in gulp bundle-size with output from filesize 🏗 Replace logging in gulp bundle-size with output from filesize Feb 6, 2021
Copy link
Contributor

@kristoferbaxter kristoferbaxter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up! Does this make the default on_local_build?

@kristoferbaxter
Copy link
Contributor

@rsimha An updated version of filesize was published with the necessary change.

@rsimha
Copy link
Contributor Author

rsimha commented Feb 8, 2021

Thanks for fixing this up! Does this make the default on_local_build?

It does indeed! Screenshot is included in the PR description.

@rsimha An updated version of filesize was published with the necessary change.

Thank you! Will update and merge this once all tests are green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants