Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃彈 Stop running visual diff tests on Travis #32546

Merged
merged 2 commits into from
Feb 9, 2021
Merged

馃彈 Stop running visual diff tests on Travis #32546

merged 2 commits into from
Feb 9, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Feb 9, 2021

They're already being run on CircleCI, and we're shutting off Travis soon.

@rsimha rsimha self-assigned this Feb 9, 2021
danielrozenberg
danielrozenberg approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@danielrozenberg danielrozenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an explicit check for Travis PRs in tasks/visual-diff/index.js, should change that too

build-system/pr-check/visual-diff-tests.js Outdated Show resolved Hide resolved
@danielrozenberg danielrozenberg mentioned this pull request Feb 9, 2021
Closed
@rsimha
Copy link
Contributor Author

rsimha commented Feb 9, 2021 •
edited

This worked.

Travis: https://travis-ci.com/github/ampproject/amphtml/jobs/481651644
CircleCI: https://app.circleci.com/pipelines/github/ampproject/amphtml/1534/workflows/8ae5ab2f-2a24-41c8-96f2-cbf5d071dfe3/jobs/14666

@rsimha rsimha merged commit 0c3ee8e into ampproject:master Feb 9, 2021
@rsimha rsimha deleted the 2021-02-09-VisDiffTravis branch February 9, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielrozenberg danielrozenberg danielrozenberg approved these changes

Assignees

@rsimha rsimha

Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rsimha @danielrozenberg @ampprojectbot