Sync for validator/cpp/htmlparser #32570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 356367509
|
Hey @ampproject/wg-caching! These files were changed: |
…Slash reported by fuzzer. PiperOrigin-RevId: 356367850
PiperOrigin-RevId: 356368763
PiperOrigin-RevId: 356368946
- Misc fixes and greater html5 compliance. Only 5 tests of 1500 webkit testcases failing. The broken test cases are not critical to amp parsing requirements. - Updated html5 testdataset (git clone git@github.com:html5lib/html5lib-tests.git). - Double the testcase coverage from ~750 to ~1500. - Corrects column numbers for <?xml|php|doctype etc. tags. PiperOrigin-RevId: 356380828
…dByte PiperOrigin-RevId: 356386700
Fix fuzz_parser: Crash in fuzz_parser.cc (b/168830101) Fix fuzz_parser: Crash in htmlparser::Allocator<htmlparser::Node>::FreeBlocks (b/168379832) All these test cases were pretty large HTML with hundreds of nodes and attributes. Tests were passing for less than 10 runs but failing for 100 runs. Reduced pressure on stack by allocating objects on heap, plus additional fix in tokenizer. PiperOrigin-RevId: 356416503
honeybadgerdontcare
approved these changes
Feb 9, 2021
PiperOrigin-RevId: 356606309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request.