Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃彈 Rewrite gulp lint using the nodejs API of eslint #32576

Merged
merged 2 commits into from
Feb 12, 2021
Merged

馃彈 Rewrite gulp lint using the nodejs API of eslint #32576

merged 2 commits into from
Feb 12, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Feb 10, 2021

This is the first in a series of PRs that modernize our development tasks.

PR Highlights:

  • Directly use the eslint nodejs API
  • Eliminate file streaming via gulp.src
  • Remove dependencies gulp-eslint, gulp-eslint-if-fixed, gulp-debounce, and lazypipe
  • Remove --watch and --quiet (on-the-fly IDE linting has made them obsolete)

Notes:

Partial fix for #32585

@rsimha rsimha self-assigned this Feb 10, 2021
@rsimha rsimha marked this pull request as ready for review February 10, 2021 15:30
@amp-owners-bot
Copy link

Hey @wassgha! These files were changed:

testing/amp-performance-extension/measure.js

@rsimha rsimha requested review from danielrozenberg and removed request for estherkim and dvoytenko February 10, 2021 19:56
@rsimha rsimha requested review from jridgewell and removed request for erwinmombay February 12, 2021 14:41
@rsimha rsimha merged commit 2bd092c into ampproject:master Feb 12, 2021
@rsimha rsimha deleted the 2021-02-09-GulpLint branch February 12, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants