🏗 Fix linter when using dict({...spread})

[alanorozco]

My linting/formatting environment was not working for a particular file until I realized the linter failed when encountering it:

[09:23:26] TypeError in plugin "gulp-eslint"
Message:
    Cannot read property 'raw' of undefined
Occurred while linting file-abc.js:123

This is caused by lint plugin local/dict-string-keys failing when using a spread operator inside dict().

dict({...spreadOperatorBreaksLinter});

We likely want to forbid this, which this change accomplishes.

// Found: idKeysAreNotOkay.The Object Literal Expression passed into `dict` must only contain string keyed properties. (at 2:7)
   dict({idKeysAreNotOkay: true});
// ------^

// Found: spreadOperatorIsNotOkay. The Object Literal Expression passed into `dict` must only contain string keyed properties. (at 5:7)
   dict({...spreadOperatorIsNotOkay});
// ------^

Alternatively, we could follow the object definition to ensure it's a dict() but that is probably more work than it's worth.

[amp-owners-bot]

Hey @erwinmombay, @jridgewell! These files were changed:

build-system/eslint-rules/dict-string-keys.js

[erwinmombay]

agree with "probably more work than it's worth."