馃彈 Add fail-fast behavior to CircleCI PR builds #32595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #32575, we added fail-fast behavior to CircleCI builds. See #32575 (comment) for why this is a good idea.
The change was reverted in #32589 because failing fast during push builds could cancel steps that establish baselines for
master
commits (e.g. bundle-size, visual diff).This PR reinstates #32575, but only for PR builds.
Sample logs: