Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃彈 Rewrite gulp ava using the ava CLI #32602

Merged
merged 2 commits into from
Feb 12, 2021
Merged

馃彈 Rewrite gulp ava using the ava CLI #32602

merged 2 commits into from
Feb 12, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Feb 10, 2021 •
edited

Another in a series of PRs that modernize our development tasks.

PR Highlights:

  • Directly use the ava CLI
  • Rename test files to match the auto-discovery pattern **/*.test.js
  • Eliminate file streaming via gulp.src
  • Remove dependency gulp-ava

Partial fix for #32585

@rsimha rsimha self-assigned this Feb 10, 2021
@rsimha rsimha merged commit 86f822f into ampproject:master Feb 12, 2021
@rsimha rsimha deleted the 2021-02-10-Ava branch February 12, 2021 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwinmombay erwinmombay erwinmombay approved these changes

@kristoferbaxter kristoferbaxter Awaiting requested review from kristoferbaxter

@danielrozenberg danielrozenberg Awaiting requested review from danielrozenberg

Assignees

@rsimha rsimha

Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable WG: infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rsimha @erwinmombay @ampprojectbot