Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃彈 Remove gulp streaming from a few developer tasks #32623

Merged
merged 7 commits into from
Feb 13, 2021
Merged

馃彈 Remove gulp streaming from a few developer tasks #32623

merged 7 commits into from
Feb 13, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Feb 12, 2021

This is another in a series of PRs that modernize our development tasks.

PR highlights:

  • Remove gulp file streaming from server-tests, presubmit, caches-json, performance-urls, and get-zindex
  • Opportunistic bugfixes:
    • Make file I/O async where possible
    • Add bing to the list of expected caches in caches.json
    • Fail task on parsing errors in caches-json and performance-urls
    • Minor logging cleanup

For easy reviewing (without whitespace-only changes), use this link: https://github.com/ampproject/amphtml/pull/32623/files?w=1

Partial fix for #32585

Copy link
Contributor

@rcebulko rcebulko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think touching all of these files is a good opportunity to take advantage of async file I/O. There's a lot of disk reads that are blocking atm

build-system/tasks/caches-json.js Outdated Show resolved Hide resolved
build-system/tasks/caches-json.js Outdated Show resolved Hide resolved
build-system/tasks/get-zindex/index.js Show resolved Hide resolved
build-system/tasks/performance-urls.js Outdated Show resolved Hide resolved
build-system/tasks/presubmit-checks.js Outdated Show resolved Hide resolved
build-system/tasks/presubmit-checks.js Outdated Show resolved Hide resolved
build-system/tasks/presubmit-checks.js Show resolved Hide resolved
build-system/tasks/presubmit-checks.js Show resolved Hide resolved
build-system/tasks/server-tests.js Show resolved Hide resolved
@rsimha
Copy link
Contributor Author

rsimha commented Feb 12, 2021

I think touching all of these files is a good opportunity to take advantage of async file I/O. There's a lot of disk reads that are blocking atm

All comments addressed. Also opportunistically cleaned up logging in presubmit. A+++ review, would request again.

@rsimha rsimha merged commit 0989bfe into ampproject:master Feb 13, 2021
@rsimha rsimha deleted the 2021-02-11-GulpStreaming branch February 13, 2021 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants