♻️ Move RTC manager to a service #32728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcebulko
reviewed
Feb 18, 2021
|
@rcebulko sorry, I forgot to add monetization reviewers. |
calebcordry
reviewed
Feb 19, 2021
| return this.getBlockRtc_().then((shouldBlock) => | ||
| shouldBlock | ||
| ? undefined | ||
| : Services.realTimeConfigForDoc( |
There was a problem hiding this comment.
should we leave this wrapped in a try/catch?
There was a problem hiding this comment.
It used to be:
if (!! AMP.RealTimeConfigManager) {
try {
return new AMP.RealTimeConfigManager(
...
The try/catch, at that time, would prevent rtc issues from breaking the entire runtime. Now that everything is wrapped in the promise and ran asynchronously, the consequence of not using try/catch is much smaller. Throwing exceptions should not be the expected thing anyways, so I feel keeping try/catch nowadays is unnecessarily defensive.
calebcordry
reviewed
Feb 19, 2021
calebcordry
approved these changes
Feb 19, 2021
|
@calebcordry I would like to, but RTV slots are full now. We can still try looking at the beta numbers (last time I didn't think it helped though). |
rcebulko
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo #32386
#32713 Ran into this issue, and this PR has it fixed. The root cause is that different amp-ad elements are incorrectly sharing the same service instance.