Experiment turning on splitted vendor integration JS #32763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerivq
force-pushed
the
enable-vendors
branch
from
534d17a
to
bfdabe0
Compare
lannka
approved these changes
Feb 26, 2021
powerivq
force-pushed
the
enable-vendors
branch
2 times, most recently
from
ce2092c
to
00eb481
Compare
micajuine-ho
approved these changes
Mar 11, 2021
powerivq
force-pushed
the
enable-vendors
branch
7 times, most recently
from
3b06a6d
to
6068e53
Compare
|
reassigning to @rsimha for build changes :) |
powerivq
force-pushed
the
enable-vendors
branch
from
6068e53
to
65a1ffb
Compare
|
@powerivq Curious: Were the build changes in this PR reverted? (Looks like the original commit was amended after it was reviewed, which makes it hard to tell if / why something changed.) |
|
@rsimha Yes they are reverted. There was merge conflict and have been reverted during rebasing so there is no history of that. |
caroqliu
added a commit
to caroqliu/amphtml
that referenced
this pull request
Apr 1, 2021
caroqliu
added a commit
to caroqliu/amphtml
that referenced
this pull request
Apr 8, 2021
caroqliu
added a commit
that referenced
this pull request
Apr 13, 2021
* Prototype * Remove loader comment and unused firstLayoutCompleted * Move sandbox flags to src/core/3p-frame * Move name to Preact layer * . * Replace getFrameAttributes * ProxyIframeEmbed, IframeEmbed, Instagram refactor * Bring back InstagramDef.Api * Undo export * Move src to ProxyIframeEmbed * Fix imports * Restore Instagram props * Fix typing * Take messageHandler instead * Give messageHandler from Twitter * Use forwardRef * Clarify comment * Dima comments * Update from changes in #32763 * Add unit tests * Update setHeightStyle * Use useMemo for count * getPreconnects returns array * Add 3p-frame and iframe files to eslint allowlist * height as string not object * Extract helper * Remove win from render body * Calculate name and src together * `src` should not be in the dependency array * Remove options * Update src/preact/component/iframe.js Co-authored-by: Justin Ridgewell <justin@ridgewell.name> Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
rileyajones
pushed a commit
to rileyajones/amphtml
that referenced
this pull request
Apr 16, 2021
* Prototype * Remove loader comment and unused firstLayoutCompleted * Move sandbox flags to src/core/3p-frame * Move name to Preact layer * . * Replace getFrameAttributes * ProxyIframeEmbed, IframeEmbed, Instagram refactor * Bring back InstagramDef.Api * Undo export * Move src to ProxyIframeEmbed * Fix imports * Restore Instagram props * Fix typing * Take messageHandler instead * Give messageHandler from Twitter * Use forwardRef * Clarify comment * Dima comments * Update from changes in ampproject#32763 * Add unit tests * Update setHeightStyle * Use useMemo for count * getPreconnects returns array * Add 3p-frame and iframe files to eslint allowlist * height as string not object * Extract helper * Remove win from render body * Calculate name and src together * `src` should not be in the dependency array * Remove options * Update src/preact/component/iframe.js Co-authored-by: Justin Ridgewell <justin@ridgewell.name> Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
rochapablo
pushed a commit
to rochapablo/amphtml
that referenced
this pull request
Aug 30, 2021
* Prototype * Remove loader comment and unused firstLayoutCompleted * Move sandbox flags to src/core/3p-frame * Move name to Preact layer * . * Replace getFrameAttributes * ProxyIframeEmbed, IframeEmbed, Instagram refactor * Bring back InstagramDef.Api * Undo export * Move src to ProxyIframeEmbed * Fix imports * Restore Instagram props * Fix typing * Take messageHandler instead * Give messageHandler from Twitter * Use forwardRef * Clarify comment * Dima comments * Update from changes in ampproject#32763 * Add unit tests * Update setHeightStyle * Use useMemo for count * getPreconnects returns array * Add 3p-frame and iframe files to eslint allowlist * height as string not object * Extract helper * Remove win from render body * Calculate name and src together * `src` should not be in the dependency array * Remove options * Update src/preact/component/iframe.js Co-authored-by: Justin Ridgewell <justin@ridgewell.name> Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the vendor specific integration js rather than
f.jsthat contains all the vendors.