馃彈 Lazy building 3p integrations #32772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @rsimha! These files were changed: |
rsimha
suggested changes
Feb 20, 2021
powerivq
force-pushed
the
fix-lazy-build-3p
branch
from
88f5008
to
a80a584
Compare
powerivq
force-pushed
the
fix-lazy-build-3p
branch
2 times, most recently
from
08acda6
to
7337a2a
Compare
|
@rsimha updated to fix conflicts. mind take another look? |
powerivq
force-pushed
the
fix-lazy-build-3p
branch
from
7337a2a
to
328a7ed
Compare
rsimha
reviewed
Mar 24, 2021
build-system/server/lazy-build.js
Outdated
| @@ -15,18 +15,24 @@ | |||
| */ | |||
| 'use strict'; | |||
|
|
|||
| const {generateBundles} = require('../tasks/3p-vendor-helpers'); | |||
There was a problem hiding this comment.
Consolidate this with the other require statement from the same file.
build-system/server/lazy-build.js
Outdated
| const argv = require('minimist')(process.argv.slice(2)); | ||
| const { | ||
| doBuildExtension, | ||
| maybeInitializeExtensions, | ||
| getExtensionsToBuild, | ||
| } = require('../tasks/extension-helpers'); | ||
| const {buildVendorLazily} = require('../tasks/3p-vendor-helpers'); |
There was a problem hiding this comment.
Consistency nit: The "lazy" part comes from how the function is called and not what it does. Can we name this doBuild3pVendor to be consistent with doBuildJs?
Comment on lines
+145
to
+147
| ? new RegExp(`\\/dist\\.3p\\/${VERSION}\\/vendor\\/([^\/]*)\\.js`) // '/dist.3p/21900000/vendor/*.js' | ||
| : /\/dist\.3p\/current\/vendor\/([^\/]*)\.max\.js/; // '/dist.3p/current/vendor/*.max.js' |
| } | ||
|
|
||
| /** | ||
| * Generate bundles for all JS to be built. |
There was a problem hiding this comment.
nit: Should this be Generate bundles for all 3p vendors to be built?
powerivq
force-pushed
the
fix-lazy-build-3p
branch
from
328a7ed
to
36f8850
Compare
|
@rsimha thanks! updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, 3p integrations cannot be lazily built. This PR fixes the lazy building so that
gulpcan defer building 3p integration JS files till needed.