Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Assist.js: Add a shared FrameService to assistjs extension #32784

Merged
merged 35 commits into from
Feb 25, 2021
Merged

✨ Assist.js: Add a shared FrameService to assistjs extension #32784

merged 35 commits into from
Feb 25, 2021

Commits on Jan 26, 2021

  1. Create the skeleton of the new extension for assist.js: amp-google-as… 

    …sistant-assistjs. It consists of one shared service and multiple custom elements.
    @ychsieh
    ychsieh committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    21ffb96 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into assistjs

    @ychsieh
    ychsieh committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    c44c038 View commit details
    Browse the repository at this point in the history

  3. Remove unneeded regenerator- 

    runtime dependency in package.json
    @ychsieh
    ychsieh committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    8a194be View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. - Add/modify copyright statement and header comment for each file 

    - Add appropriate validator rules for the new extension
- Add more detailed description about what this extension does
    @ychsieh
    ychsieh committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    d0844da View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into assistjs

    @ychsieh
    ychsieh committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    b18e9c2 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2021

  1. Merge remote-tracking branch 'upstream/master' into assistjs

    @ychsieh
    ychsieh committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    66e40b7 View commit details
    Browse the repository at this point in the history

  2. Add a shared service(AssistjsConfigService) and a new config element.… 

    … Also includes some minor refactoring.

The service provides config to other components and the element take prespecified config json.
    @ychsieh
    ychsieh committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    3662c29 View commit details
    Browse the repository at this point in the history

  3. Fix styling and remove commented code in AssistjsFrameService.

    @ychsieh
    ychsieh committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    dae219b View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. Merge remote-tracking branch 'upstream/master' into assistjs

    @ychsieh
    ychsieh committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    b7a97d4 View commit details
    Browse the repository at this point in the history

  2. Improve config service: 

    - Ensure config json retrieval
- Move widget iframe url creation into one single place.
- Add assertion to ensure there's only one config element on the page

Minor fixes:
- Replace await usage with then to avoid extra dependencies.
- Update validator rules for the invisible config element
    @ychsieh
    ychsieh committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    c4eab76 View commit details
    Browse the repository at this point in the history

  3. Fix prettify errors.

    @ychsieh
    ychsieh committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    a7be424 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2021

  1. Unit test fix and some minor fixes.

    @ychsieh
    ychsieh committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    2654cd6 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into assistjs

    @ychsieh
    ychsieh committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    3ab4470 View commit details
    Browse the repository at this point in the history

  3. Fix lint errors.

    @ychsieh
    ychsieh committed Feb 8, 2021
    Configuration menu
    Copy the full SHA
    c0a830f View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2021

  1. Merge remote-tracking branch 'upstream/master' into assistjs

    @ychsieh
    ychsieh committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    d317cb3 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. Update extensions/amp-google-assistant-assistjs/0.1/assistjs-frame-se… 

    …rvice.js

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
    @ychsieh @jridgewell
    ychsieh and jridgewell committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    09d7d5b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into assistjs

    @ychsieh
    ychsieh committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    bda9bb7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'assistjs' of https://github.com/ychsieh/amphtml into as… 

    …sistjs
    @ychsieh
    ychsieh committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    3c2e7df View commit details
    Browse the repository at this point in the history

  4. Minor fixes.

    @ychsieh
    ychsieh committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    615589e View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2021

  1. Merge remote-tracking branch 'upstream/master' into assistjs

    @ychsieh
    ychsieh committed Feb 16, 2021
    Configuration menu
    Copy the full SHA
    2070b0b View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2021

  1. Merge remote-tracking branch 'upstream/master' into assistjs

    @ychsieh
    ychsieh committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    88e193e View commit details
    Browse the repository at this point in the history

  2. Fix errors caused by not having this.win in a service class(non-AMP.B… 

    …aseElement).

Also add a config service mock to the unit test.
    @ychsieh
    ychsieh committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    8464e66 View commit details
    Browse the repository at this point in the history

  3. ampdoc.getWin() is forbidden. Replace it with "window" directly.

    @ychsieh
    ychsieh committed Feb 17, 2021
    Configuration menu
    Copy the full SHA
    6b471fd View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. - Append iframe to the document after frame src is retrieved 

    - Parse config in config element to save a DOM query
- Delete assistjs-frame-service.js. Add it in next PR with real usage.
    @ychsieh
    ychsieh committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    88a525d View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into assistjs

    @ychsieh
    ychsieh committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    88cb168 View commit details
    Browse the repository at this point in the history

  3. Fix FrameService reference errors and lint errors.

    @ychsieh
    ychsieh committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    0bcce79 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2021

  1. Merge remote-tracking branch 'upstream/master' into assistjs

    @ychsieh
    ychsieh committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    c165319 View commit details
    Browse the repository at this point in the history

  2. Add a shared FrameService for all custom elements to handle requests … 

    …from underlying iframes.

Actual implementation of two endpoints: OpenMic and SendTextQuery is empty now and will be implemented in upcoming PRs.
    @ychsieh
    ychsieh committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    98d516e View commit details
    Browse the repository at this point in the history

  3. Use ampdoc.whenready instead to fix the loading error. 

    Add sandbox attributes to all iframes.
    @ychsieh
    ychsieh committed Feb 22, 2021
    Configuration menu
    Copy the full SHA
    67d62c0 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2021

  1. Merge remote-tracking branch 'upstream/master' into assistjs

    @ychsieh
    ychsieh committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    63e2c2a View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2021

  1. Update extensions/amp-google-assistant-assistjs/0.1/assistjs-frame-se… 

    …rvice.js

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
    @ychsieh @jridgewell
    ychsieh and jridgewell committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    f4c4dc9 View commit details
    Browse the repository at this point in the history

  2. Update extensions/amp-google-assistant-assistjs/0.1/assistjs-frame-se… 

    …rvice.js

Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
    @ychsieh @jridgewell
    ychsieh and jridgewell committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    88f9ce9 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into assistjs

    @ychsieh
    ychsieh committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    266a660 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'assistjs' of https://github.com/ychsieh/amphtml into as… 

    …sistjs
    @ychsieh
    ychsieh committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    7a380ca View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2021

  1. Merge remote-tracking branch 'upstream/master' into assistjs

    @ychsieh
    ychsieh committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    4135608 View commit details
    Browse the repository at this point in the history