Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Bento Selector: Correctly deregister events in OptionShim #32786

Merged
merged 1 commit into from Feb 22, 2021
Merged

馃悰 Bento Selector: Correctly deregister events in OptionShim #32786

merged 1 commit into from Feb 22, 2021

Conversation

caroqliu
Copy link
Contributor

Related to #28282

@caroqliu caroqliu requested a review from krdwan February 22, 2021 16:17
krdwan
krdwan approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@krdwan krdwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! LGTM

@caroqliu caroqliu merged commit b8b8409 into ampproject:master Feb 22, 2021
caroqliu added a commit to caroqliu/amphtml that referenced this pull request Feb 23, 2021
@caroqliu
name -> type (ampproject#32786)
8eb1bf4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krdwan krdwan krdwan approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@caroqliu @krdwan @ampprojectbot