Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗 Execute integration tests on both prod and canary config, with experiments derandomized #32808

Merged
merged 6 commits into from Feb 25, 2021
Merged

🏗 Execute integration tests on both prod and canary config, with experiments derandomized #32808

merged 6 commits into from Feb 25, 2021

Conversation

danielrozenberg
Copy link
Member

@danielrozenberg danielrozenberg commented Feb 22, 2021 •
edited

Fixes #25720:

  • splits the integration/module and integration/nomodule tests on CircleCI to integration/module-prod, integration/module-canary, integration/nomodule-prod, integration/nomodule-canary
  • Runs Math.round() on all experiment percentage ratios to remove any randomness from the tests

See the CircleCI build for this PR to see the results

@amp-owners-bot
Copy link

amp-owners-bot bot commented Feb 22, 2021 •
edited

Hey @rsimha! These files were changed:

.circleci/config.yml
build-system/pr-check/module-tests.js
build-system/pr-check/nomodule-tests.js

@danielrozenberg danielrozenberg force-pushed the e2e-configs branch 20 times, most recently from 8c5d9f8 to 9236aba Compare February 23, 2021 21:04
@danielrozenberg danielrozenberg changed the title [DO NOT MERGE] WIP execute e2e tests on both prod and canary configs 🏗 Execute integration tests on both prod and canary config, with experiments derandomized Feb 23, 2021
@danielrozenberg danielrozenberg mentioned this pull request Feb 24, 2021
Closed
rsimha
rsimha reviewed Feb 24, 2021
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few cosmetic changes. Looks great otherwise!

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
@danielrozenberg danielrozenberg removed the request for review from samouri February 24, 2021 19:50
@danielrozenberg danielrozenberg merged commit 01f115a into ampproject:master Feb 25, 2021
@danielrozenberg danielrozenberg deleted the e2e-configs branch February 25, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lannka lannka lannka approved these changes

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Override all experiment percentage to 100% for integration tests
4 participants
@danielrozenberg @lannka @rsimha @ampprojectbot