Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃彈 Ensure that z-index table is up to date #32830

Merged
merged 2 commits into from Feb 24, 2021

Conversation

alanorozco
Copy link
Member

@alanorozco alanorozco commented Feb 23, 2021

Successful --fix run: (truncated)

gulp get-zindex --fix

[10:10:23] Using gulpfile ~/git/amphtml/gulpfile.js
[10:10:23] Starting 'get-zindex'...

diff --git a/css/Z_INDEX.md b/css/Z_INDEX.md
index 437b768da..a1c673789 100644
--- a/css/Z_INDEX.md
+++ b/css/Z_INDEX.md
@@ -1,7 +1,9 @@
-Run `gulp get-zindex` to generate this file.
+Run `gulp get-zindex --fix` to generate this file.
 
 | selector                                     | z-index    | file                                      |
-| -------------------------------------------- | ---------- | --------------------------------------- |
+| -------------------------------------------- | ---------- | ----------------------------------------- |
 | .i-amphtml-expanded-mode amp-story-grid-lay  | auto       | extensions/amp-story/1.0/amp-story.css    |
 | .i-amphtml-expanded-mode amp-story-grid-lay  | auto       | extensions/amp-story/1.0/amp-story.css    |
+| amp-sidebar::part(c)                         | inherit    | extensions/amp-sidebar/1.0/amp-sidebar.cs |
+| amp-sidebar::part(sidebar)                   | inherit    | extensions/amp-sidebar/1.0/amp-sidebar.cs |
 | amp-story amp-consent                        | initial    | extensions/amp-story/1.0/amp-story.css    |
@@ -9,4 +11,6 @@ Run `gulp get-zindex` to generate this file.
 | .amp-access-scroll-sheet                     | 2147483647 | extensions/amp-access-scroll/0.1/amp-acce |
+| .i-amphtml-onetap-google-iframe              | 2147483647 | extensions/amp-onetap-google/0.1/amp-onet |
 | amp-sidebar                                  | 2147483647 | extensions/amp-sidebar/0.1/amp-sidebar.cs |
 | amp-sidebar                                  | 2147483647 | extensions/amp-sidebar/0.2/amp-sidebar.cs |
+| amp-sidebar                                  | 2147483647 | extensions/amp-sidebar/1.0/amp-sidebar.cs |
 | .amp-apester-fullscreen                      | 2147483646 | extensions/amp-apester-media/0.1/amp-apes |
@@ -59,3 +63,5 @@ Run `gulp get-zindex` to generate this file.
 | amp-app-banner                               | 13         | extensions/amp-app-banner/0.1/amp-app-ban |
+| amp-ad-sticky-padding                        | 12         | extensions/amp-ad/0.1/amp-ad.css          |
 | amp-sticky-ad-top-padding                    | 12         | extensions/amp-sticky-ad/1.0/amp-sticky-a |
+| amp-ad[sticky]                               | 11         | extensions/amp-ad/0.1/amp-ad.css          |
 | amp-sticky-ad                                | 11         | extensions/amp-sticky-ad/1.0/amp-sticky-a |
@@ -72,2 +78,3 @@ Run `gulp get-zindex` to generate this file.
 | .i-amphtml-image-slider-bar                  | 3          | extensions/amp-image-slider/0.1/amp-image |
+| amp-story-cta-layer                          | 3          | extensions/amp-story-auto-ads/0.1/amp-sto |
 | amp-story-page[active] .i-amphtml-story-pag  | 3          | extensions/amp-story/1.0/amp-story-page-a |
@@ -82,2 +89,3 @@ Run `gulp get-zindex` to generate this file.
 | amp-story-grid-layer                         | 2          | extensions/amp-story/1.0/amp-story.css    |
+| .amp-story-player-exit-control-button        | 1          | css/amp-story-player-iframe.css           |
 | .i-amphtml-layout-size-defined > [fallback]  | 1          | css/ampshared.css                         |
@@ -86,3 +94,3 @@ Run `gulp get-zindex` to generate this file.
 | .amp-video-eq                                | 1          | css/video-autoplay.css                    |
-| i-amphtml-video-mask                         | 1          | css/video-autoplay.css                  |
+| .i-amphtml-video-mask                        | 1          | css/video-autoplay.css                    |
 | amp-addthis .i-amphtml-addthis-close         | 1          | extensions/amp-addthis/0.1/amp-addthis.cs |

[10:10:23] Wrote css/Z_INDEX.md
[10:10:23] Finished 'get-zindex' after 720 ms

A check failure run is the same, except it errors-out when the table is incomplete.

@amp-owners-bot
Copy link

Hey @rsimha! These files were changed:

build-system/pr-check/checks.js

@alanorozco alanorozco requested review from rsimha and removed request for danielrozenberg February 24, 2021 00:06
@alanorozco alanorozco merged commit bf0e1f3 into ampproject:master Feb 24, 2021
@@ -32,7 +33,7 @@ const tableOptions = {
hsep: ' | ',
};

const preamble = 'Run `gulp get-zindex` to generate this file.';
const preamble = '**Run `gulp get-zindex --fix` to generate this file.**';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raxsha @processprocess @lannka @gmajoulet

PSA for people who've modified css/Z_INDEX.md in the past. (Thank you for your dilligence!)

The command to update said file now requires --fix:

gulp get-zindex --fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants