Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Allow htmlFormat to be used with other hash params #32836

Merged
merged 1 commit into from Feb 23, 2021

Conversation

caoboxiao
Copy link
Contributor

Set htmlFormat and editor content individually.

Fixes #23088, allowing htmlFormat=xxx to be used with url=xxx.

@amp-owners-bot
Copy link

amp-owners-bot bot commented Feb 23, 2021

Hey @ampproject/wg-caching! These files were changed:

validator/js/webui/@polymer/webui-mainpage/webui-mainpage.html

@honeybadgerdontcare
Copy link
Contributor

Could confirm this works as intended via the instructions at https://github.com/ampproject/amphtml/tree/master/validator/js/webui#running-your-own-web-ui

@caoboxiao
Copy link
Contributor Author

Could confirm this works as intended via the instructions at https://github.com/ampproject/amphtml/tree/master/validator/js/webui#running-your-own-web-ui

Confirmed at my local machine

@honeybadgerdontcare
Copy link
Contributor

Confirmed at my local machine

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow passing htmlFormat together with url parameter
3 participants