♿ [Story a11y] Make CTAs not tabbable when not on active page #32840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet, @newmuis, @Enriqe! These files were changed: |
5 tasks
processprocess
approved these changes
Feb 24, 2021
|
Sorry I didn't catch this before merge. We should use an attribute name that is impossible for publishers to use, to avoid collisions (e.g. |
This was referenced Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable in-page CTAs from tabbing when they are not on an active page. When they are on an active page, they should have their original tabindex. We can store the original tabindex on
data-orig-tabindexwhen a page is initialized, and updatetabindexwhen it becomes active or inactive.Adding
tabindex="-1"to the pages directly does not prevent the children from being tabbed, so the directatags need to be affected