馃彈 amp-timeago:1.0 - Use timeago.js library #32844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
approved these changes
Feb 23, 2021
dvoytenko
approved these changes
Feb 24, 2021
| @@ -60,6 +60,11 @@ export function Timeago({ | |||
| return undefined; | |||
| } | |||
| const observer = new win.IntersectionObserver((entries) => { | |||
| let {lang} = node.ownerDocument.documentElement; | |||
| if (lang === 'unknown') { | |||
There was a problem hiding this comment.
Never seen "unknown", but I do see an empty string. There's also navigator.language that could be helpful for defaults.
There was a problem hiding this comment.
I got unknown from this reference: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/lang, should I remove this check?
re: package.json changes, this was done in #32809 for 0.1 separately.
There was a problem hiding this comment.
Going to merge this PR for now, let's follow up separately if we decide to remove "unknown"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
amp-timeago 1.0from using thetimeagopackage inthird_party/to the runtime dependency packagethird_party/timeagojsas it's no longer needed given the above.amp-timeagoand corresponding docs to uselocalevalues of the formatxxorxx-XX(case-insensitive) in accordance with BCP 47. Note: Prior formats (xxXX) are still supported but removed from docs to move away from non-standard formatting, and timeago.js library formats (xx_XX) were not added to the larger set of supported formats.This PR is a follow up to #32809. Related to #29246.