Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃彈 Rewrite dep-check with esbuild and babel #32845

Merged
merged 3 commits into from Feb 24, 2021
Merged

馃彈 Rewrite dep-check with esbuild and babel #32845

merged 3 commits into from Feb 24, 2021

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Feb 23, 2021

This is another in a series of PRs that modernize our development tasks.

PR highlights:

  • Rewrite dep-check with esbuild and babel
  • Rewrite getSrcs(), which was only writing one file (and rename it to getEntryPointModule())
  • Rewrite getGraph() to use esbuild and babel (and rename it to getModuleGraph())
  • Clean up flattenGraph()
  • Eliminate the use of browserify, babelify, gulp.dest, and vinyl-source-stream
  • Delete vinyl-source-stream from package.json (others need more work)

Screenshots:

image

Reference: https://esbuild.github.io/api/#metafile

Partial fix for #32585

@rsimha rsimha self-assigned this Feb 23, 2021
@rsimha rsimha requested a review from samouri February 23, 2021 23:14
@rsimha rsimha added this to In progress in `wg-infra` Fixit Week 2/2021 via automation Feb 23, 2021
@samouri
Copy link
Member

samouri commented Feb 23, 2021

Doesn't esbuild have an optional "metafile" with the entire dep tree?
See: https://esbuild.github.io/api/#metafile

@rsimha rsimha changed the title 馃彈 Rewrite dep-check without gulp.dest and vinyl-source-stream 馃彈 Rewrite dep-check with esbuild and babel Feb 24, 2021
@rsimha
Copy link
Contributor Author

rsimha commented Feb 24, 2021

Doesn't esbuild have an optional "metafile" with the entire dep tree?
See: esbuild.github.io/api/#metafile

Nice! Done in latest commit.

`wg-infra` Fixit Week 2/2021 automation moved this from In progress to Reviewer approved Feb 24, 2021
@rsimha rsimha merged commit 85fbc06 into ampproject:master Feb 24, 2021
`wg-infra` Fixit Week 2/2021 automation moved this from Reviewer approved to Done Feb 24, 2021
@rsimha rsimha deleted the 2021-02-22-DepCheck branch February 24, 2021 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants