Make Templates an ampdoc-level service to avoid FIE and shadowdoc conflicts #32853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
force-pushed
the
run3/templates-ampdoc
branch
from
f1cb1cb
to
18527c2
Compare
jridgewell
approved these changes
Feb 24, 2021
calebcordry
approved these changes
Feb 24, 2021
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Feb 27, 2021
…flicts (ampproject#32853) * Make Templates an ampdoc-level service to avoid FIE and shadowdoc conflicts * cleanup * fix presubmits * fixes * fix ads tests * fix amp-list tests * fix amp-date-display tests
jridgewell
added a commit
that referenced
this pull request
Mar 2, 2021
…hadowdoc conflicts (#32976) * Make Templates an ampdoc-level service to avoid FIE and shadowdoc conflicts (#32853) * Make Templates an ampdoc-level service to avoid FIE and shadowdoc conflicts * cleanup * fix presubmits * fixes * fix ads tests * fix amp-list tests * fix amp-date-display tests * Use adoptServiceFactoryForEmbedDoc Co-authored-by: Dima Voytenko <dvoytenko@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.