Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃彈 amp-video-interface can use links from amp.dev #32856

Merged
merged 2 commits into from Feb 24, 2021
Merged

馃彈 amp-video-interface can use links from amp.dev #32856

merged 2 commits into from Feb 24, 2021

Conversation

alanorozco
Copy link
Member

No description provided.

@alanorozco alanorozco marked this pull request as ready for review February 24, 2021 15:58
rsimha
rsimha approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did something change with the "file added by this PR" situation?

@alanorozco
Copy link
Member Author

@rsimha No, they're just no longer checked: <!-- markdown-link-check-disable -->. Which I think is fine, since they're all generated.

@alanorozco alanorozco merged commit dc5c2d2 into ampproject:master Feb 24, 2021
@alanorozco alanorozco deleted the video-list-amp-dev branch February 24, 2021 18:09
@alanorozco alanorozco restored the video-list-amp-dev branch February 24, 2021 18:09
@alanorozco alanorozco deleted the video-list-amp-dev branch February 24, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alanorozco @rsimha @ampprojectbot