Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ampproject/amphtml] ♿ [Story a11y] Pagination buttons alt text #32861

Merged
merged 6 commits into from Feb 24, 2021
Merged

[ampproject/amphtml] ♿ [Story a11y] Pagination buttons alt text #32861

merged 6 commits into from Feb 24, 2021

Conversation

processprocess
Copy link
Contributor

@processprocess processprocess commented Feb 24, 2021 •
edited

Contributes to #32493

  • Moves alt-text onto button element.
  • Allows button element to be fused on mobile(previous implementation used wrapper element as button on mobile).
  • Uses htmlFor instead of renderAsElement to follow amp-story pattern.

@processprocess processprocess mentioned this pull request Feb 24, 2021
Closed
7 tasks
@processprocess processprocess marked this pull request as ready for review February 24, 2021 16:42
@amp-owners-bot
Copy link

Hey @gmajoulet, @newmuis, @Enriqe! These files were changed:

extensions/amp-story/1.0/pagination-buttons.css
extensions/amp-story/1.0/pagination-buttons.js

@processprocess processprocess changed the title Pagination buttons alt text. [ampproject/amphtml] ♿ [Story a11y] Pagination buttons alt text Feb 24, 2021
mszylkowski
mszylkowski approved these changes Feb 24, 2021
View reviewed changes
Copy link
Contributor

@mszylkowski mszylkowski left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, but LGTM. Make sure Percy tests are fixed!

@processprocess processprocess added this to In progress in wg-stories Sprint via automation Feb 24, 2021
@processprocess processprocess merged commit 626637a into ampproject:master Feb 24, 2021
wg-stories Sprint automation moved this from In progress to Done Feb 24, 2021
@processprocess processprocess deleted the pagination-alt branch February 24, 2021 22:09
gmajoulet
gmajoulet reviewed Feb 25, 2021
View reviewed changes
extensions/amp-story/1.0/pagination-buttons.css
/* Navigation buttons. These are only displayed on desktop. */
.i-amphtml-story-button-move {
display: none !important;
/* Navigation button element. Visibly hidden on mobile but focusable by screen readers. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are they click targets that could cover some content? Should we add pointer-events: none? That might create some P0s.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The click targets could cover content but they're within the 48px area reserved for navigating.
Patch PR for adding pointer-events: none #32917

Screen Shot 2021-02-25 at 11 51 19 AM

@processprocess processprocess mentioned this pull request Feb 25, 2021
Merged
@mszylkowski mszylkowski mentioned this pull request Mar 1, 2021
Closed
@mszylkowski mszylkowski removed this from Done in wg-stories Sprint Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmajoulet gmajoulet gmajoulet left review comments

@mszylkowski mszylkowski mszylkowski approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@processprocess @gmajoulet @mszylkowski @ampprojectbot