馃彈 Make bundle-size reporting failures non-blocking #32864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`wg-infra` Fixit Week 2/2021
automation
moved this from In progress
to Reviewer approved
Feb 24, 2021
danielrozenberg
approved these changes
Feb 24, 2021
dvoytenko
approved these changes
Feb 24, 2021
|
This worked: https://app.circleci.com/pipelines/github/ampproject/amphtml/2654/workflows/fc5b7cee-b67e-4e2c-a0e0-8dd57fb9005e/jobs/30168/parallel-runs/0/steps/0-107 (even though reporting didn't fail this time) Merging to unblock development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bundle-size GCP app is down, and this is preventing CI from working reliably.
This PR makes reporting non-blocking for CI. The status will still be missing, but an override approval can address that.
I'm thinking this PR should be permanent, since it decouples failures in one system (GCP) from another (CI).