馃悰 [amp-carousel 0.1] Fix race for setting slideWidth_ #32866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samouri
approved these changes
Feb 25, 2021
| @@ -721,7 +721,8 @@ export class AmpSlideScroll extends BaseSlides { | |||
| ); | |||
| return false; | |||
| } | |||
| showIndexArr.forEach((showIndex, loopIndex) => { | |||
|
|
|||
| showIndexArr.sort().forEach((showIndex, loopIndex) => { | |||
There was a problem hiding this comment.
super nit: I prefer .sort() on its own line instead of chained with forEach. that is because it actually modified the showIndexArr in addition to returning it.
i.e.
showIndexArry.sort();
showIndexArr.forEach(...)
samouri
reviewed
Feb 25, 2021
| @@ -907,6 +907,19 @@ describes.realWin( | |||
| expect(ampSlideScroll.hasAttribute('loop')).to.be.false; | |||
| }); | |||
|
|
|||
| it.only('sets the correct scrollLeft for looping carousel', async () => { | |||
micajuine-ho
changed the title
style.order for looping slides
micajuine-ho
force-pushed
the
loopOrder
branch
from
25a341d
to
141a1b4
Compare
dvoytenko
approved these changes
Feb 25, 2021
caroqliu
approved these changes
Feb 25, 2021
Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com>
This was referenced Mar 3, 2021
ampprojectbot
pushed a commit
that referenced
this pull request
Mar 3, 2021
* init * fix race * Update extensions/amp-carousel/0.1/slidescroll.js Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> (cherry picked from commit 25bb462)
ampprojectbot
pushed a commit
that referenced
this pull request
Mar 3, 2021
* init * fix race * Update extensions/amp-carousel/0.1/slidescroll.js Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com> (cherry picked from commit 25bb462)
|
Hello. This issue persists in amp-carousel 0.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #32920
There's a race between setting the
slidesWidth_viaattachedCallbackand using theslidesWidth_inlayoutCallback(expected to be non-zero, initially, ingetScrollLeftForIndex_()).Let's set a flag to see if it's been set and manually set if it hasn't been yet.