Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰馃彈 Fix building HTML fixtures during integration tests #32886

Merged
merged 1 commit into from
Feb 25, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions build-system/tasks/integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,11 @@ class Runner extends RuntimeTestRunner {

/** @override */
async maybeBuild() {
if (argv.nobuild) {
return;
if (!argv.nobuild) {
await buildRuntime();
}
await buildRuntime();
// buildRuntime will clean the directory! We have to do this afterwards.
await buildTransformedHtml();
}
}

Expand Down Expand Up @@ -85,7 +86,6 @@ async function integration() {
buildNewServer();
htmlTransform = require('../server/new-server/transforms/dist/transform')
.transform;
await buildTransformedHtml();

maybePrintArgvMessages();

Expand Down