♻️ Attach firstElement and messageArray to assert errors #32887
Conversation
| } | ||
|
|
||
| return subValue; | ||
| }); |
There was a problem hiding this comment.
@rsimha Do you know why this might thing these lines were not covered by tests? Every line is indeed covered
There was a problem hiding this comment.
Not sure why it claimed zero coverage.
From CI logs, unit test coverage was successfully uploaded for the last commit in this PR: https://app.circleci.com/pipelines/github/ampproject/amphtml/2836/workflows/8eda1669-cac3-4370-a4f3-548652ffaf9f/jobs/32913/parallel-runs/0/steps/0-110
And codecov shows that the lines added by this PR are indeed covered (from running tests after this landed on master): https://codecov.io/gh/ampproject/amphtml/commit/ee8ac1edf18b76d00158ef949587b7e272fdad8a/ (link needs GH login)
Perhaps there was a blip during the PR build's coverage processing? Not sure. Can keep an eye, but can't think of any action items now.
There was a problem hiding this comment.
Unless... you changed the code in one commit and added tests in a follow up commit, and these statuses are from the first commit that didn't have the coverage?
Mirrors existing functionality in standalone assertion helpers