Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isolate state in test-amp-a4a.js #32894

Merged
merged 1 commit into from Feb 26, 2021
Merged

Isolate state in test-amp-a4a.js #32894

merged 1 commit into from Feb 26, 2021

Conversation

calebcordry
Copy link
Member

  • Moves all code inside a describes block.
  • Removes any references to window.

Should help with weird flakes due to persistent state across runs. Closes #29517

@calebcordry
Copy link
Member Author

@rileyajones could you please review the build-system/tasks/presubmit-checks.js change?

@calebcordry calebcordry merged commit 89046ce into ampproject:master Feb 26, 2021
@calebcordry calebcordry deleted the flaky-tests branch February 26, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerivq powerivq powerivq approved these changes

@lannka lannka lannka approved these changes

@rileyajones rileyajones rileyajones approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🧪 Clean up tests in test-amp-a4a.js
5 participants
@calebcordry @powerivq @lannka @rileyajones @ampprojectbot