🏗 Remove almost all gulp streaming from the compilation pipeline
#32903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I diffed all the |
rsimha
commented
Feb 25, 2021
`wg-infra` Fixit Week 2/2021
automation
moved this from In progress
to Reviewer approved
Feb 25, 2021
samouri
approved these changes
Feb 25, 2021
jridgewell
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another in a series of PRs that modernize our development tasks.
PR highlights:
css/index.jsanddist.jswithout file streamingcopyCss()tocss/, etc.)gulp-fileandgulp-watchfrompackage.jsonI've verified that the
build/anddist/output directories (including 3p and tools) are byte-for-byte identical with the same file structure before and after this PR.After this, the last remaining item is to get rid of all the file streaming in
build-system/compile/compile.js.Partial fix for #32585