Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Fixit: create src/core with eslint rule disallowing imports #32916

Merged
merged 6 commits into from Feb 26, 2021
Merged

♻️ Fixit: create src/core with eslint rule disallowing imports #32916

merged 6 commits into from Feb 26, 2021

Conversation

rcebulko
Copy link
Contributor

Part of #32693 . This PR:

  • creates src/core
  • includes lint config to disallow exporting from outside this directory
  • moves src/assert into src/core, updating references

@rcebulko
Copy link
Contributor Author

/cc @jridgewell for visibility

jridgewell
jridgewell approved these changes Feb 25, 2021
View reviewed changes
src/core/.eslintrc.js Show resolved Hide resolved
src/core/OWNERS Outdated Show resolved Hide resolved
jridgewell
jridgewell approved these changes Feb 25, 2021
View reviewed changes
src/core/OWNERS Outdated Show resolved Hide resolved
rcebulko
rcebulko commented Feb 25, 2021
View reviewed changes
Copy link
Contributor Author

@rcebulko rcebulko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bumping bundle size

@kristoferbaxter kristoferbaxter merged commit a8b0fb1 into ampproject:master Feb 26, 2021
@rcebulko rcebulko deleted the no-import branch February 26, 2021 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samouri samouri samouri left review comments

@kristoferbaxter kristoferbaxter kristoferbaxter approved these changes

@jridgewell jridgewell jridgewell approved these changes

@caroqliu caroqliu caroqliu approved these changes

@dvoytenko dvoytenko Awaiting requested review from dvoytenko

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rcebulko @kristoferbaxter @jridgewell @samouri @caroqliu @ampprojectbot